Re: Wrong return code in vacuumdb when multiple jobs are used

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Julien Rouhaud <rjuju123(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Wrong return code in vacuumdb when multiple jobs are used
Date: 2019-05-04 11:04:59
Message-ID: CAA4eK1K+MtdYvvQO5QgEEh0iDiSdavnr3z3TBYWw3SEf1i_c2Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, May 4, 2019 at 2:45 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Sat, May 04, 2019 at 10:35:23AM +0200, Julien Rouhaud wrote:
> > While reading vacuumdb code, I just noticed that it can return 0 if an
> > error happen when -j is used, if errors happen on the last batch of
> > commands.
>
> Yes, I agree that this is wrong. GetIdleSlot() is much more careful
> about that than vacuum_one_database(), so your patch looks good at
> quick glance.
>

The fix looks good to me as well.

--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Federico Razzoli 2019-05-04 11:38:41 season of docs proposal
Previous Message Amit Kapila 2019-05-04 09:25:13 Re: Unhappy about API changes in the no-fsm-for-small-rels patch