| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com> |
| Cc: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Japin Li <japinli(at)hotmail(dot)com> |
| Subject: | Re: [BUG] wrong refresh when ALTER SUBSCRIPTION ADD/DROP PUBLICATION |
| Date: | 2021-08-23 04:59:14 |
| Message-ID: | CAA4eK1K++DDFdXqmddGUkYePmKEihHSfYTYFQ=RiV1jR5-wWxQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Aug 7, 2021 at 6:53 PM houzj(dot)fnst(at)fujitsu(dot)com
<houzj(dot)fnst(at)fujitsu(dot)com> wrote:
>
> Personally, I also think it will be better to make the behavior consistent.
> Attach the new version patch make both ADD and DROP behave the same as SET PUBLICATION
> which refresh all the publications.
>
I think we can have tests in the separate test file (alter_sub_pub.pl)
like you earlier had in one of the versions. Use some meaningful names
for tables instead of temp1, temp2 as you had in the previous version.
Otherwise, the code changes look good to me.
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2021-08-23 05:01:11 | Re: [BUG] wrong refresh when ALTER SUBSCRIPTION ADD/DROP PUBLICATION |
| Previous Message | Dilip Kumar | 2021-08-23 04:22:50 | Re: pgsql: pgstat: Bring up pgstat in BaseInit() to fix uninitialized use o |