| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | Peter Smith <smithpb2250(at)gmail(dot)com>, Jeff Davis <pgsql(at)j-davis(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Invalidate the subscription worker in cases where a user loses their superuser status |
| Date: | 2023-10-12 05:40:36 |
| Message-ID: | CAA4eK1JztFkYeVANuH0Ja_c3zqDjTyz0j15xQqwCDRPokYhWgw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Oct 8, 2023 at 8:22 AM vignesh C <vignesh21(at)gmail(dot)com> wrote:
>
--- a/src/include/catalog/pg_subscription.h
+++ b/src/include/catalog/pg_subscription.h
@@ -127,6 +127,7 @@ typedef struct Subscription
* skipped */
char *name; /* Name of the subscription */
Oid owner; /* Oid of the subscription owner */
+ bool ownersuperuser; /* Is the subscription owner a superuser? */
bool enabled; /* Indicates if the subscription is enabled */
bool binary; /* Indicates if the subscription wants data in
* binary format */
We normally don't change the exposed structure in back branches as
that poses a risk of breaking extensions. In this case, if we want, we
can try to squeeze some padding space or we even can fix it without
introducing a new member. OTOH, it is already debatable whether to fix
it in back branches, so we can even commit this patch just in HEAD.
Thoughts?
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Drouvot, Bertrand | 2023-10-12 05:42:28 | Re: Add a new BGWORKER_BYPASS_ROLELOGINCHECK flag |
| Previous Message | Michael Paquier | 2023-10-12 05:23:27 | Re: Remove MSVC scripts from the tree |