Re: logicalrep_message_type throws an error

On Thu, Jul 20, 2023 at 9:10 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Wed, Jul 19, 2023 at 10:08 AM Ashutosh Bapat
> <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com> wrote:
> >
> > On Wed, Jul 19, 2023 at 9:01 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> > >
> > > On Tue, Jul 18, 2023 at 10:27 AM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> > > >
> > > > Or can we use snprintf() writing "??? (%d)" to a fixed length char[8 +
> > > > 11] allocated on the stack instead?
> > > >
> > >
> > > In the above size calculation, shouldn't it be 7 + 11 where 7 is for
> > > (3 (???) + 1 for space + 2 for () + 1 for terminating null char) and
> > > 11 is for %d? BTW, this avoids dynamic allocation of the err string in
> > > logicalrep_message_type() but we can't return a locally allocated
> > > string, so do you think we should change the prototype of the function
> > > to get this as an argument and then use it both for valid and invalid
> > > cases?
> >
> > There are other places in the code which do something similar by using
> > statically allocated buffers like static char xya[SIZE]. We could do
> > that here. The caller may decide whether to pstrdup this buffer
> > further or just use it one time e.g. as an elog or printf argument.
> >
>
> Okay, changed it accordingly.
>

oops, forgot to attach the patch.

--
With Regards,
Amit Kapila.