Re: Improve doc on parallel stream changes for Stream Abort message

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Anthonin Bonnefoy <anthonin(dot)bonnefoy(at)datadoghq(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Improve doc on parallel stream changes for Stream Abort message
Date: 2025-06-24 05:26:08
Message-ID: CAA4eK1Jyn-iXXd3JnZA8w1nirVHqGxNMHonHbJRVCtmsJSqZbQ@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Jun 23, 2025 at 2:10 PM Anthonin Bonnefoy
<anthonin(dot)bonnefoy(at)datadoghq(dot)com> wrote:
>
> While adding parsing of logical replication to Wireshark[1], I've
> found the Stream Abort description possibly misleading. Stream Abort
> will have the Abort LSN and TS when parallel streaming is enabled.
> However, the documentation only mentions "This field is available
> since protocol version 4" which could be interpreted (at least, I've
> interpreted it this way) as "this field will always present with
> protocol version 4".
>
> The attached patch adds a "(only present for parallel stream)" mention
> to the Abort LSN and TS documentation, akin to what's done for
> parallel transactions.
>

How about a slightly modified version like: (a) The LSN of the abort
operation, present only when the change stream can be applied in
parallel. This field is available since protocol version 4. (b) Abort
timestamp of the transaction, present only when the change stream can
be applied in parallel. The value is in number of microseconds since
PostgreSQL epoch (2000-01-01). This field is available since protocol
version 4.

--
With Regards,
Amit Kapila.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Banck 2025-06-24 05:51:08 Re: Safeguards against incorrect fd flags for fsync()
Previous Message Sutou Kouhei 2025-06-24 05:11:50 Re: Make COPY format extendable: Extract COPY TO format implementations