Re: [Proposal] Adding Log File Capability to pg_createsubscriber

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: shveta malik <shveta(dot)malik(at)gmail(dot)com>
Cc: Gyan Sreejith <gyan(dot)sreejith(at)gmail(dot)com>, Kuroda, Hayato/黒田 隼人 <kuroda(dot)hayato(at)fujitsu(dot)com>, Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Euler Taveira <euler(at)eulerto(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Peter Smith <smithpb2250(at)gmail(dot)com>
Subject: Re: [Proposal] Adding Log File Capability to pg_createsubscriber
Date: 2026-03-23 07:16:36
Message-ID: CAA4eK1JyYHPgaPTow5co8wBh8Ga+fx=vqHLhk2zHeqdOGYN4Vg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Mar 23, 2026 at 8:46 AM shveta malik <shveta(dot)malik(at)gmail(dot)com> wrote:
>
> On Sun, Mar 22, 2026 at 4:39 AM Gyan Sreejith <gyan(dot)sreejith(at)gmail(dot)com> wrote:
> >
> >
> > On Sat, Mar 21, 2026 at 5:57 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> >>
> >>
> >> Based on the above information, can we consider renaming the above
> >>
> >> functions to report_createsub_log() and report_createsub_fatal()?
> >>
> >> Other than the above point, 0001 LGTM.
> >
> >
> > I have renamed the functions.
> >
>
> 001 looks good.
>

Pushed 0001.

--
With Regards,
Amit Kapila.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Antonin Houska 2026-03-23 07:22:14 Teach isolation tester about injection points in background workers
Previous Message shveta malik 2026-03-23 07:05:02 Re: Skipping schema changes in publication