Re: Wrong comment for ReplicationSlotCreate

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Daniil Davydov <3danissimo(at)gmail(dot)com>
Cc: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Wrong comment for ReplicationSlotCreate
Date: 2026-01-06 11:43:31
Message-ID: CAA4eK1JuLE6Zmb1Q1hrCXZzXk9tCQv1pPOod0e0CXufRAvqVHg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Jan 5, 2026 at 4:01 PM Daniil Davydov <3danissimo(at)gmail(dot)com> wrote:
>
> Good catch!
> I am not sure that we should put both fixes together, so I'll put your fix in a
> separate patch.
>

It is okay to fix the typo patch in HEAD but the other patch related
to fixing the outdated comment needs to be backpatched, so pushed
separately. Thanks!

--
With Regards,
Amit Kapila.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2026-01-06 11:44:02 Re: Checking join outer relation uniqueness to prevent unnecessary memoization
Previous Message VASUKI M 2026-01-06 11:10:00 Re: [PATCH] Expose checkpoint reason to completion log messages.