| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | "Tsunakawa, Takayuki" <tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Re: [bug fix] Cascading standby cannot catch up and get stuck emitting the same message repeatedly |
| Date: | 2016-11-24 07:24:21 |
| Message-ID: | CAA4eK1JpSYiZrH5vWZmwc_=VQetai3hHobJkxdaiGtwXvCRh=g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Nov 24, 2016 at 10:29 AM, Tsunakawa, Takayuki
<tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com> wrote:
> From: pgsql-hackers-owner(at)postgresql(dot)org
>> [mailto:pgsql-hackers-owner(at)postgresql(dot)org] On Behalf Of Amit Kapila
>> Thanks for the clarification, I could reproduce the issue and confirms that
>> patch has fixed it. Find logs of cascading standby at PG9.2 Head and Patch
>> attached (I have truncated few lines at end of server log generated in Head
>> as those were repetitive). I think the way you have directly explained
>> the bug steps in code comments is not right (think if we start writing bug
>> steps for each bug fix, how the code will look like). So I have modified
>> the comment to explain the situation and reason of check, see if you find
>> that as okay?
>
> Thank you, I'm happy with your comment.
>
Okay, I have marked the patch as 'Ready for Committer'.
--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Etsuro Fujita | 2016-11-24 07:30:24 | Re: Push down more full joins in postgres_fdw |
| Previous Message | Ashutosh Bapat | 2016-11-24 06:40:09 | Re: Declarative partitioning - another take |