| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
| Cc: | Amit Langote <amitlangote09(at)gmail(dot)com>, houzj(dot)fnst(at)fujitsu(dot)com, Greg Nancarrow <gregn4422(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, vignesh C <vignesh21(at)gmail(dot)com>, David Rowley <dgrowleyml(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Tsunakawa, Takayuki" <tsunakawa(dot)takay(at)fujitsu(dot)com>, tanghy(dot)fnst(at)fujitsu(dot)com |
| Subject: | Re: Parallel INSERT (INTO ... SELECT ...) |
| Date: | 2021-03-18 03:28:14 |
| Message-ID: | CAA4eK1JoGpPfMyQuFOgEhb+gmH6odA39enMjUx-563McA4H1JA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Mar 18, 2021 at 8:30 AM Justin Pryzby <pryzby(at)telsasoft(dot)com> wrote:
>
> diff --git a/doc/src/sgml/ref/create_table.sgml b/doc/src/sgml/ref/create_table.sgml
> index ff1b642722..d5d356f2de 100644
> --- a/doc/src/sgml/ref/create_table.sgml
> +++ b/doc/src/sgml/ref/create_table.sgml
> @@ -1338,8 +1338,10 @@ WITH ( MODULUS <replaceable class="parameter">numeric_literal</replaceable>, REM
> If a table parameter value is set and the
> equivalent <literal>toast.</literal> parameter is not, the TOAST table
> will use the table's parameter value.
> - Specifying these parameters for partitioned tables is not supported,
> - but you may specify them for individual leaf partitions.
> + These parameters, with the exception of
> + <literal>parallel_insert_enabled</literal>,
> + are not supported on partitioned tables, but may be specified for
> + individual leaf partitions.
> </para>
>
Your patch looks good to me. While checking this, I notice a typo in
the previous patch:
- planner parameter <varname>parallel_workers</varname>.
+ planner parameter <varname>parallel_workers</varname> and
+ <varname>parallel_insert_enabled</varname>.
Here, it should be /planner parameter/planner parameters.
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | houzj.fnst@fujitsu.com | 2021-03-18 03:34:34 | RE: Parallel INSERT (INTO ... SELECT ...) |
| Previous Message | Peter Geoghegan | 2021-03-18 03:23:34 | Re: New IndexAM API controlling index vacuum strategies |