Re: Fix LOCK_TIMEOUT handling in slotsync worker

On Mon, Dec 8, 2025 at 1:06 PM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
>
> I have nit comment:
>
> ```
> - if (ShutdownRequestPending)
> + if (SlotSyncCtx->stopSignaled)
> {
> ereport(LOG,
> - errmsg("replication slot synchronization worker is shutting down on receiving SIGINT"));
> + errmsg("replication slot synchronization worker is shutting down because promotion is triggered"));
> ```
>
> In the error message, “because promotion is triggered" sound a little redundant, can be just:
>
> "replication slot synchronization worker is shutting down due to promotion"
>

We have a number of existing similar messages like: "logical
replication parallel apply worker for subscription \"%s\" will stop
because of a parameter change". So, how about: "replication slot
synchronization worker will stop because promotion is triggered"?

--
With Regards,
Amit Kapila.