| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Peter Smith <smithpb2250(at)gmail(dot)com> |
| Cc: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Distinguish publication exclusions in object addresses |
| Date: | 2026-09-16 08:24:45 |
| Message-ID: | CAA4eK1Jj61+hsEFYzApf-TrLbSKdeg6iHrO64j6jj2ROsYyP4A@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Sep 16, 2026 at 1:21 PM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>
> On Wed, Sep 16, 2026 at 5:41 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> >
> > On Wed, Sep 16, 2026 at 12:23 PM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
> >
> > Can you share an example of such a case?
> >
>
> My example was using 'publication relation' (not 'publication excluded
> relation') and I've already shared it.
>
> But that bug (?) already exists because this logic appears only aware
> of PUBLICATIONRELMAP rels and is not accounting for FOR ALL TABLES
> etc, so it reports an error like
> ERROR: "t1" is not a published relation of publication "pub"
> even though table public.t1 does exist and really is a published
> relation of pub.
>
Right, but it is a different case as discussed. So, I would still
prefer to keep the same message to keep the code simple. Also, I would
like to push this patch after changing the Assert location as pointed
by Nisha unless you or others have any other comment.
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Chao Li | 2026-09-16 08:26:26 | Re: Distinguish publication exclusions in object addresses |
| Previous Message | Peter Eisentraut | 2026-09-16 08:22:44 | Re: Use C11 alignas instead of palloc/malloc for alignment |