| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Melih Mutlu <m(dot)melihmutlu(at)gmail(dot)com> |
| Cc: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, "shiy(dot)fnst(at)fujitsu(dot)com" <shiy(dot)fnst(at)fujitsu(dot)com>, "Takamichi Osumi (Fujitsu)" <osumi(dot)takamichi(at)fujitsu(dot)com>, Euler Taveira <euler(at)eulerto(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Allow logical replication to copy tables in binary format |
| Date: | 2023-03-07 03:10:20 |
| Message-ID: | CAA4eK1JiU5JHGnhFDX5=C=vj7c2D1hMfstPLqHNYSThBA1iZAQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Mar 1, 2023 at 7:58 PM Melih Mutlu <m(dot)melihmutlu(at)gmail(dot)com> wrote:
>
> Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, 1 Mar 2023 Çar, 15:02 tarihinde şunu yazdı:
>>
>
> That was my intention in the beginning with this patch. Then the new option also made some sense at some point, and I added copy_binary option according to reviews.
> The earlier versions of the patch didn't have that. Without the new option, this patch would also be smaller.
>
> But before changing back to the point where these are all tied to binary option without a new option, I think we should decide if that's really the ideal way to do it.
>
As per what I could read in this thread, most people prefer to use the
existing binary option rather than inventing a new way (option) to
binary copy in the initial sync phase. Do you agree? If so, it is
better to update the patch accordingly as this is the last CF for this
release and we have a limited time left.
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Imseih (AWS), Sami | 2023-03-07 03:21:46 | Re: Record queryid when auto_explain.log_verbose is on |
| Previous Message | Chris Travers | 2023-03-07 03:07:16 | Re: Moving forward with TDE |