| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Imran Zaheer <imran(dot)zhir(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Fix comment in report_sequence_errors() |
| Date: | 2026-06-08 09:15:44 |
| Message-ID: | CAA4eK1Jh-=rzmV6us_YwT1eqEunO9jD6yYFeaZP+2Fs0Kbr71Q@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jun 8, 2026 at 5:58 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Sun, Jun 07, 2026 at 07:35:05PM +0500, Imran Zaheer wrote:
> > However, the actual warning message emitted and the logic that
> > populates missing_seqs_idx both refer to sequences that are missing on
> > the publisher side, not the subscriber.
> >
> > The fix is to replace "subscriber" with "publisher" in that comment line.
>
> The first comment could also make clear the fact that we care about
> inconsistent definitions on the subscriber side. Grabbed these,
> thanks.
>
The patch looks good to me. IIUC, you are planning to commit this one
along with some other typo/minor fixes, right?
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nisha Moond | 2026-06-08 09:22:02 | Re: Proposal: Conflict log history table for Logical Replication |
| Previous Message | Ashutosh Sharma | 2026-06-08 08:53:28 | Re: synchronized_standby_slots behavior inconsistent with quorum-based synchronous replication |