Re: [Patch] add new parameter to pg_replication_origin_session_setup

On Wed, Feb 11, 2026 at 10:53 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Wed, Feb 4, 2026 at 12:38 AM Heikki Linnakangas <hlinnaka(at)iki(dot)fi> wrote:
> >
> > The new error message is not great:
> >
> > postgres=# select pg_replication_origin_session_setup('myorigin', 12345678);
> > ERROR: could not find replication state slot for replication origin
> > with OID 1 which was acquired by 12345678
> >
> > Firstly, replication origin is not an OID. Secondly, it's a little
> > confusing because the "replication state slot" is in fact present.
> > However, it's currently inactive, i.e. not "acquired" by the given PID.
> >
> > I propose to change that to:
> >
> > postgres=# select pg_replication_origin_session_setup('myorigin', 12345678);
> > ERROR: replication origin with ID 1 is not active for PID 12345678
> >
> > That's more in line with this neighboring message:
> >
> > ERROR: replication origin with ID 1 is already active for PID 701228
> >
>
> +1 for the new message.
>

Heikki, would you like to take care of improvements proposed by you?
Otherwise, I am happy to take care of them.

--
With Regards,
Amit Kapila.