From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
---|---|
To: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
Cc: | thomas(dot)munro(at)gmail(dot)com, tgl(at)sss(dot)pgh(dot)pa(dot)us, pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | Re: A question about wording in messages |
Date: | 2022-09-20 04:30:40 |
Message-ID: | CAA4eK1JeygCQDKUFt-DAXyM1iFN-Q4tEjFDFhoAsYTmEn4B59g@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, Sep 16, 2022 at 12:29 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> > > >
> > > > +1, I saw that today and thought it was outside our usual style.
> > > > The whole thing is awfully verbose for a GUC description, too.
> > > > Maybe
> > > >
> > > > "Maximum distance to read ahead in WAL to prefetch data blocks."
> > >
> > > +1
> > >
> > > For "we", I must have been distracted by code comment style. For the
> > > extra useless verbiage, it's common for GUC description to begin "This
> > > control/affects/blah" like that, but I agree it's useless noise.
> > >
> > > For the other cases, Amit's suggestion of 'server' seems sensible to me.
> >
> > Thaks for the opinion. I'm fine with that, too.
> >
>
> So, the change related to wal_decode_buffer_size needs to be
> backpatched to 15 whereas other message changes will be HEAD only, am
> I correct?
>
I would like to pursue as per above unless there is more feedback on this.
--
With Regards,
Amit Kapila.
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2022-09-20 04:30:50 | Re: Patch proposal: make use of regular expressions for the username in pg_hba.conf |
Previous Message | Thomas Munro | 2022-09-20 04:16:32 | Re: Proposal to use JSON for Postgres Parser format |