| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Peter Smith <smithpb2250(at)gmail(dot)com> |
| Cc: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: DOCS - Clarify the publication 'publish_via_partition_root' default value. |
| Date: | 2025-12-17 12:04:15 |
| Message-ID: | CAA4eK1Ja2S5gRB2+zN7e5aYvg5oU_k7q4zr=HJ4DFDrx9LiYhA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Dec 17, 2025 at 2:29 AM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>
> On Tue, Dec 16, 2025 at 7:39 PM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
> >
> > >
> > > AFAIK, Chao's improved text is mostly good, except I think there might
> > > be some nuances when there are multiple levels of partitioning.
> > >
> > > For example, maybe you need to make this change?
> > > BEFORE
> > > When set to true, changes are published using the identity and schema
> > > of the partitioned table
> > > AFTER
> > > When set to true, changes are published using the identity and schema
> > > of the root partitioned table
> > > ~~~
> >
> > Agreed to add “root”.
> >
>
> PSA v2 done that way.
>
LGTM. As this is not any bug fix rather a text improvement, so it is
good to fix this in HEAD only.
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2025-12-17 12:23:56 | Re: Replace is_publishable_class() with relispublishable column in pg_class |
| Previous Message | Bertrand Drouvot | 2025-12-17 11:57:13 | Re: Fix memory leak in gist_page_items() of pageinspect |