Re: pgsql: Try again to fix the way the scanjoin_target is used with partia

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Robert Haas <rhaas(at)postgresql(dot)org>, pgsql-committers <pgsql-committers(at)postgresql(dot)org>
Subject: Re: pgsql: Try again to fix the way the scanjoin_target is used with partia
Date: 2016-06-18 03:16:23
Message-ID: CAA4eK1JX8Wc0pKqn6SmhEWm2GdZE-E2wmLv+tHRbY+m-tK7tDw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Sat, Jun 18, 2016 at 7:44 AM, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
wrote:
>
> On Sat, Jun 18, 2016 at 7:06 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> >
> > Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> writes:
> > > On Sat, Jun 18, 2016 at 6:11 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > >> Was this supposed to fix the "ORDER/GROUP BY expression not found in
> > >> targetlist" problem?
> > >> If so, it hasn't ...
> >
> > > Can you please share why you think so?
> >
> > Run the regression tests with the settings mentioned in
> > https://www.postgresql.org/message-id/22782.1466100870@sss.pgh.pa.us
> >
> > You'll get a lot of cosmetic diffs (parallelized plans in EXPLAIN
> > and/or varying output row orders), but also half a dozen of the
> > aforesaid failure.
> >
>
> I think I got the reason of those failures.

Patch fixing the failures along with a new test case is attached with this
mail

With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com

Attachment Content-Type Size
fix_scanjoin_pathtarget_v4.patch application/octet-stream 2.2 KB

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2016-06-18 03:26:09 Re: pgsql: Try again to fix the way the scanjoin_target is used with partia
Previous Message Tom Lane 2016-06-18 03:08:27 pgsql: Fix parallel-safety markings for contrib/dblink.

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2016-06-18 03:26:09 Re: pgsql: Try again to fix the way the scanjoin_target is used with partia
Previous Message Tom Lane 2016-06-18 02:41:53 Whether to back-patch fix for aggregate transtype width estimates