Re: Supporting huge pages on Windows

On Fri, Mar 31, 2017 at 8:05 AM, Tsunakawa, Takayuki
<tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com> wrote:
> From: Amit Kapila [mailto:amit(dot)kapila16(at)gmail(dot)com]
>> The latest patch looks good to me apart from one Debug message, so I have
>> marked it as Ready For Committer.
>
> Thank you so much!
>
>
>> + ereport(DEBUG1,
>> + (errmsg("disabling huge pages")));
>>
>> I think this should be similar to what we display in sysv_shmem.c as below:
>>
>> elog(DEBUG1, "mmap(%zu) with MAP_HUGETLB failed, huge pages disabled: %m",
>> allocsize);
>
> I understood you suggested this to make the reason clear for disabling huge pages. OK, done as follows.
>
> + elog(DEBUG1, "CreateFileMapping(%llu) with SEC_LARGE_PAGES failed "
> + "due to insufficient large pages, huge pages disabled",
> + size);
>

You should use %zu instead of %llu to print Size type of variable.

--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com