Re: pgsql: Revert "Avoid the creation of the free space map for small heap

On Tue, May 7, 2019 at 10:03 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Tue, May 7, 2019 at 9:51 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> > I'm just worried that that's an untested scenario.
> >
>
> I can test it. Basically, without revert of the patch, I can create a
> table with a few records (so as to ensure that there is no FSM). And
> then revert the patch and upgrade the database and perform few dml
> operations on that table and see what happens?
>

I have tested this both with and without an upgrade. This tests that
an existing v12 DB (with some missing FSM files) works with the
updated backend and the same works even if we do upgrade. If anyone
else can think of some other scenario's, please let me know.

--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com