Re: Memory leak in WAL sender with pgoutput (v10~)

On Wed, Dec 4, 2024 at 7:39 AM Zhijie Hou (Fujitsu)
<houzj(dot)fnst(at)fujitsu(dot)com> wrote:
>
> On Wednesday, December 4, 2024 8:55 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> >
>
> > Amit has concerns with other code paths that could be
> > similarly leaking. I'm not sure if this is worth waiting too long
> > based on how local the fix for the existing leak is with any of these
> > solutions.
>
> It appears there is an additional memory leak caused by allocating publication
> names within the CacheMemoryContext, as noted in [1]. And it can also be fixed by
> creating a separate memctx for publication names under the logical decoding
> context. I think the approach makes sense since the lifespan of publication
> names should ideally align with that of the logical decoding context.
>

Yeah, I don't think we can go with the proposed patch for the local
memory context as it is.

--
With Regards,
Amit Kapila.