Re: Confusing comment for function ExecParallelEstimate

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: "Wu, Fei" <wufei(dot)fnst(at)cn(dot)fujitsu(dot)com>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Confusing comment for function ExecParallelEstimate
Date: 2019-06-06 02:42:36
Message-ID: CAA4eK1JP==FNpzd=CHC=mnCrLPg1bN5RyZAuk8AUdLYfh_yq7Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jun 6, 2019 at 7:37 AM Wu, Fei <wufei(dot)fnst(at)cn(dot)fujitsu(dot)com> wrote:
>
> Sorry, Last mail forget to CC the mailing list.
>
> Now the comment is confusing, Maybe someone should correct it.
>

Sure, for the sake of clarity, when this code was initially introduced
in commit d1b7c1ff, the structure used was
SharedPlanStateInstrumentation, but later when it got changed to
Instrumentation structure in commit b287df70, we forgot to update the
comment. So, we should backpatch this till 9.6 where it got
introduced. I will commit this change by tomorrow or so.

--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2019-06-06 04:43:48 Re: Should we warn against using too many partitions?
Previous Message Wu, Fei 2019-06-06 02:06:50 RE: Confusing comment for function ExecParallelEstimate