Re: [PATCH] Remove trailing period from errmsg in subscriptioncmds.c

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Sahitya Chandra <sahityajb(at)gmail(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [PATCH] Remove trailing period from errmsg in subscriptioncmds.c
Date: 2026-03-09 07:45:38
Message-ID: CAA4eK1JNwsFSkjUDgEhzh_z1wXf9x7xcs_Zi6Kvx5teRf_remw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Mar 8, 2026 at 7:58 PM Sahitya Chandra <sahityajb(at)gmail(dot)com> wrote:
>
> While reading the subscription code I noticed one error message that doesn't follow the project's style: in check_remote_recovery_state() in subscriptioncmds.c, the errmsg() for the "publisher is in recovery" case ends with a period. The convention elsewhere (including the similar message a few lines above in the same file) is no trailing period.
>
> The attached one-line patch removes the trailing period from that string. No behavior change.
>

LGTM.

--
With Regards,
Amit Kapila.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Ayush Tiwari 2026-03-09 07:50:13 Re: tid_blockno() and tid_offset() accessor functions
Previous Message Bertrand Drouvot 2026-03-09 07:43:43 Re: relfilenode statistics