| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Jaime Casanova <jcasanov(at)systemguards(dot)com(dot)ec>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Japin Li <japinli(at)hotmail(dot)com>, Euler Taveira <euler(at)eulerto(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Identify missing publications from publisher while create/alter subscription. |
| Date: | 2022-03-30 05:52:30 |
| Message-ID: | CAA4eK1JNXpo91yEzt4ZQWUqaG2o9PUfzjLqyKDUVvhEjQvwFSg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Mar 29, 2022 at 8:11 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
>
> On Tue, Mar 29, 2022 at 11:02 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> >
>
> Thanks for the suggestion, I have changed the patch as suggested.
> Attached v16 patch has the changes for the same.
>
Thanks, I have one more comment.
postgres=# Alter subscription sub1 add publication pub4;
WARNING: publications "pub2", "pub4" do not exist in the publisher
ALTER SUBSCRIPTION
This gives additional publication in WARNING message which was not
part of current command but is present from the earlier time.
postgres=# Alter Subscription sub1 set publication pub5;
WARNING: publication "pub5" does not exist in the publisher
ALTER SUBSCRIPTION
SET variant doesn't give such a problem.
I feel we should be consistent here.
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2022-03-30 05:54:34 | Re: Add LZ4 compression in pg_dump |
| Previous Message | David G. Johnston | 2022-03-30 05:27:44 | Re: Granting SET and ALTER SYSTE privileges for GUCs |