| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Getting server crash on Windows when using ICU collation |
| Date: | 2017-06-17 03:41:54 |
| Message-ID: | CAA4eK1JH_8iHQNBRnC1Q_NoKTvT-WFQ3OVN92vNnRpJyNpcW2A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jun 16, 2017 at 7:42 PM, Peter Eisentraut
<peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
> On 6/16/17 06:30, Amit Kapila wrote:
>> How will this compare UTF-8 strings in UTF-8 encoding? It seems to me
>> that ideally, it should use ucol_strcollUTF8 to compare the same,
>> however, with patch, it will always ucol_strcoll as we never define
>> HAVE_UCOL_STRCOLLUTF8 flag on Windows.
>
> We have a configure check for that, but I don't know how to replicate
> that on Windows.
>
I think we can find out in which version of ICU this function has been
released and then determine the version. We already determine the
MSVC version in Windows (refer DetermineVisualStudioVersion in
src/tools/msvc/VSObjectFactory.pm). I think we can determine ICU
version with something like "unconv -V", it gives results as "uconv
v2.1 ICU 53.1".
--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2017-06-17 03:46:08 | Re: Getting server crash on Windows when using ICU collation |
| Previous Message | Amit Kapila | 2017-06-17 03:04:47 | Re: Broken hint bits (freeze) |