Re: repeated decoding of prepared transactions

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Ajin Cherian <itsajin(at)gmail(dot)com>
Cc: vignesh C <vignesh21(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: repeated decoding of prepared transactions
Date: 2021-03-02 05:28:21
Message-ID: CAA4eK1JDz=c=EL+pRJ5K8p0cFZ_kOmpD2apjQhLTgZNAF4rWng@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Mar 2, 2021 at 10:38 AM Ajin Cherian <itsajin(at)gmail(dot)com> wrote:
>
> On Tue, Mar 2, 2021 at 3:03 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> One minor comment:
> + </para>
> + <para>
> + True if the slot is enabled for decoding prepared transactions. Always
> + false for physical slots.
> + </para></entry>
> + </row>
>
> There is an extra space before Always. But when rendered in html this
> is not seen, so this might not be a problem.
>

I am just trying to be consistent with the nearby description. For example, see:
"The number of bytes that can be written to WAL such that this slot is
not in danger of getting in state "lost". It is NULL for lost slots,
as well as if <varname>max_slot_wal_keep_size</varname> is
<literal>-1</literal>."

In Pg docs, comments, you will find that there are places where we use
a single space before the new line and also places where we use two
spaces. In this case, for the sake of consistency with the nearby
description, I used two spaces.

--
With Regards,
Amit Kapila.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2021-03-02 05:31:46 Re: Re: [PATCH] regexp_positions ( string text, pattern text, flags text ) → setof int4range[]
Previous Message Isaac Morland 2021-03-02 05:22:44 Re: [PATCH] regexp_positions ( string text, pattern text, flags text ) → setof int4range[]