| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Manuel Reyes Bravo <manuelreyesbravo(at)gmail(dot)com> |
| Cc: | vignesh C <vignesh21(at)gmail(dot)com>, "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Distinguish publication exclusions in object addresses |
| Date: | 2026-09-18 03:43:06 |
| Message-ID: | CAA4eK1JCYqWPDVfrqD01Ug6vow2S7BgXXVTkrc25N8s91NTudw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Sep 17, 2026 at 7:53 PM Manuel Reyes Bravo
<manuelreyesbravo(at)gmail(dot)com> wrote:
>
> vignesh C <vignesh21(at)gmail(dot)com> wrote:
> > That seems better, here is an updated v3 version to handle the same.
> > Same patch applies on pg19 branch and tests passes in both the
> > branches.
>
> v3 no longer has the temporary table test that v2 added, I assume because
> the pg_temp_N number depends on the backend. stats_ext.sql already deals
> with that by redacting the number, and the attached top-up does the same,
> so the case stays covered:
>
> NOTICE: cannot specify relation
> "pg_temp_REDACTED.testpub_temptbl" in the publication EXCEPT clause
> (This operation is not supported for temporary tables.)
>
> It passes on both branches, and the same block run from three sessions
> at once, with temp schemas pg_temp_1, pg_temp_2 and pg_temp_3, prints the
> same line in each.
>
Thanks for sharing the testcase patch but I don't find compelling to
add it along with current patch due to: (a) it is not necessary to use
temp table to test this patch, (b) I am not sure we want to test all
negative cases especially with some special handling though I am open
to consider it separately as a test to increase code-coverage.
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | shihao zhong | 2026-09-18 03:48:23 | Re: Python/pytest test framework take two |
| Previous Message | Henson Choi | 2026-09-18 03:21:10 | Re: Row pattern recognition |