| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com> |
| Cc: | Mahendra Singh Thalor <mahi6run(at)gmail(dot)com>, Amit Langote <langote_amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Claudio Freire <klaussfreire(at)gmail(dot)com>, David Steele <david(at)pgmasters(dot)net>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Pavan Deolasee <pavan(dot)deolasee(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>, Sergei Kornilov <sk(at)zsrv(dot)org>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> |
| Subject: | Re: [HACKERS] Block level parallel vacuum |
| Date: | 2020-01-15 11:57:37 |
| Message-ID: | CAA4eK1JABaWqDnm0g9-bppEa+WhXkoV9QsA-e_mGPxXxa=jSTw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jan 15, 2020 at 10:05 AM Masahiko Sawada
<masahiko(dot)sawada(at)2ndquadrant(dot)com> wrote:
>
> Thank you for updating the patch! I have a few small comments.
>
I have adapted all your changes, fixed the comment by Mahendra related
to initializing parallel state only when there are at least two
indexes. Additionally, I have changed a few comments (make the
reference to parallel vacuum consistent, at some places we were
referring it as 'parallel lazy vacuum' and at other places it was
'parallel index vacuum').
> The
> rest looks good to me.
>
Okay, I think the patch is in good shape. I am planning to read it a
few more times (at least 2 times) and then probably will commit it
early next week (Monday or Tuesday) unless there are any major
comments. I have already committed the API patch (4d8a8d0c73).
--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| v48-0001-Allow-vacuum-command-to-process-indexes-in-parallel.patch | application/octet-stream | 80.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Atsushi Torikoshi | 2020-01-15 12:59:59 | Re: Add pg_file_sync() to adminpack |
| Previous Message | Maksim Milyutin | 2020-01-15 10:49:35 | Re: Disallow cancellation of waiting for synchronous replication |