| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | shveta malik <shveta(dot)malik(at)gmail(dot)com> |
| Cc: | Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, YeXiu <1518981153(at)qq(dot)com>, Ian Lawrence Barwick <barwick(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Skipping schema changes in publication |
| Date: | 2026-02-08 10:20:58 |
| Message-ID: | CAA4eK1J9=vfNYU=K=0pfEf=b8iZFB0FGocCOpJL1tdTY-g94uw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Feb 6, 2026 at 3:54 PM shveta malik <shveta(dot)malik(at)gmail(dot)com> wrote:
>
> On Thu, Feb 5, 2026 at 10:59 AM Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com> wrote:
> >
> > I have added the fix of the same in the latest v41 patch and added the
> > corresponding test in 101_test.pl file.
> > I have also merged the v40-0001 and v40-0002 patches to form v41-0001
> > patch and v41-0002 has the extended tests.
> >
>
> Thank You for the patched Shlok. While testing I found a case where
> table-sync and incremental-sync are not replicating same set of
> tables.
>
> I have attached the test-case and results in DifferentPubViaRoot.txt
>
> The problem happens when we have a subscriber subscribing to multiple
> pubs with different EXCEPT and different PUBLISH_VIA_PARTITION_ROOT
> value. Example:
>
> CREATE PUBLICATION pub1 for ALL TABLES EXCEPT table (tab_part_1_p1,
> tab_part_2_p2) WITH (PUBLISH_VIA_PARTITION_ROOT=true);
> CREATE PUBLICATION pub2 for ALL TABLES EXCEPT table (tab_part_2) WITH
> (PUBLISH_VIA_PARTITION_ROOT=false);
>
> We need to decide the behaviour of such a case for Apporach1.
>
It is better to disallow such combinations where combining
publications could lead to contradictory behavior. For example, pub1:
FOR ALL Tables EXCEPT (tab1) and pub2: FOR TABLE tab1. Now, combining
pub1 and pub2 via subscription should result in an ERROR. We have
similar restrictions for column lists. See section: "Warning:
Combining Column Lists from Multiple Publications" in docs [1]. Does
that sound reasonable to you?
[1] - https://www.postgresql.org/docs/devel/logical-replication-col-lists.html
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Álvaro Herrera | 2026-02-08 10:50:24 | Re: Use pg_current_xact_id() instead of deprecated txid_current() |
| Previous Message | Shinya Kato | 2026-02-08 09:14:37 | Use pg_current_xact_id() instead of deprecated txid_current() |