Re: display offset along with block number in vacuum errors

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com>
Cc: Justin Pryzby <pryzby(at)telsasoft(dot)com>, Mahendra Singh Thalor <mahi6run(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: display offset along with block number in vacuum errors
Date: 2020-08-24 05:27:17
Message-ID: CAA4eK1J50EX8TZbLaK+A3Rk0Km61_nTjHyfb3ifHLK3UmZN7qA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Aug 21, 2020 at 12:31 PM Masahiko Sawada
<masahiko(dot)sawada(at)2ndquadrant(dot)com> wrote:
>
> On Thu, 20 Aug 2020 at 21:12, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> >
> >
> > Attached are both the patches. The first one is to improve existing
> > error context information, so I think we should back-patch to 13. The
> > second one is to add additional vacuum error context information, so
> > that is for only HEAD. Does that make sense? Also, let me know if you
> > have any more comments.
>
> Yes, makes sense to me.
>
> I don't have comments on both patches. They look good to me.
>

Thanks, I have pushed the first patch. I'll will push the second one
in a day or two unless someone has comments on the same.

--
With Regards,
Amit Kapila.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2020-08-24 05:48:50 Re: Creating a function for exposing memory usage of backend process
Previous Message Fujii Masao 2020-08-24 04:13:39 Re: Creating a function for exposing memory usage of backend process