Re: Explain buffers wrong counter with parallel plans

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: "Jonathan S(dot) Katz" <jonathan(dot)katz(at)excoventures(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Adrien Nayrat <adrien(dot)nayrat(at)anayrat(dot)info>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Explain buffers wrong counter with parallel plans
Date: 2018-07-28 06:14:11
Message-ID: CAA4eK1J3cH-y9K+2DOYLLOu9zFqf+aAQgKK3BFw4c661e7FSEw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Jul 27, 2018 at 11:12 PM, Jonathan S. Katz
<jonathan(dot)katz(at)excoventures(dot)com> wrote:
>
>> On Jul 27, 2018, at 8:31 AM, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>>
>>
>> Yeah, that would be better. Today, I have tried the patch on both
>> Head and PG11 and I am getting same and correct results.
>
> I have applied the the patch to PG11beta2 and tested.
>

I think we should backpatch this till 9.6 where the parallel query was
introduced. Note, that for HEAD and 11, the patch is same. For PG10,
the patch code is same, but because surrounding code is different, the
same patch didn't apply. For 9.6, we don't need to collect stats in
ExecShutdownNode. I have tested it in all the back branches and it
works fine.

Robert,

We have done verification that the approach works and fixes the bug in
all known cases. Do you see any problem with this approach?

--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com

Attachment Content-Type Size
fix_gather_stats_PG10_v1.patch application/octet-stream 2.9 KB
fix_gather_stats_PG96_v1.patch application/octet-stream 1.3 KB
fix_gather_stats_PGHead_11_v1.patch application/octet-stream 2.9 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Minh-Quan Tran 2018-07-28 09:19:56 Re: Segfault logical replication PG 10.4
Previous Message Tom Lane 2018-07-28 03:38:57 Bizarre behavior in libpq's searching of ~/.pgpass