| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Japin Li <japinli(at)hotmail(dot)com> |
| Cc: | Petr Jelinek <petr(dot)jelinek(at)enterprisedb(dot)com>, "osumi(dot)takamichi(at)fujitsu(dot)com" <osumi(dot)takamichi(at)fujitsu(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Truncate in synchronous logical replication failed |
| Date: | 2021-04-16 09:48:31 |
| Message-ID: | CAA4eK1J35PH4T_9di0bWozZ55KCmf9kBRNWZuqAFM+S_f=S+oQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Apr 16, 2021 at 3:08 PM Japin Li <japinli(at)hotmail(dot)com> wrote:
>
> On Fri, 16 Apr 2021 at 16:52, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> > On Fri, Apr 16, 2021 at 12:55 PM Japin Li <japinli(at)hotmail(dot)com> wrote:
> > It is okay as POC but we can't change the existing function
> > RelationGetIndexAttrBitmap. It is used from other places as well. It
> > might be better to write a separate function for this, something like
> > what Osumi-San's patch is trying to do.
>
> Agreed!
>
> Hi Osumi-San, can you merge the test case in your next version?
>
+1. Your test looks reasonable to me.
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bharath Rupireddy | 2021-04-16 09:53:14 | Re: logical replication worker accesses catalogs in error context callback |
| Previous Message | Amit Kapila | 2021-04-16 09:46:18 | Re: Replication slot stats misgivings |