| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: rename SnapBuild* macros in slot.c |
| Date: | 2021-11-24 08:55:49 |
| Message-ID: | CAA4eK1+JfsZpjSTVS3g5TnAk2aBOwCi3JE1QfE4HhURb1J9Cbw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Nov 23, 2021 at 8:12 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Mon, Nov 22, 2021 at 7:47 PM Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
> >
> > On 2021-Nov-22, Amit Kapila wrote:
> >
> > > +1 for this change. This seems to be introduced by commit ec5896aed3
> > > [1] and I think it is just a typo to name these macros starting with
> > > SnapBuildOnDisk* unless I am missing something.
> >
> > Yeah, it looks pretty weird. +1 for the change on consistency grounds.
> >
>
> Okay, I will push this tomorrow unless I see any objections.
>
Pushed!
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Hans Buschmann | 2021-11-24 09:12:24 | AW: VS2022: Support Visual Studio 2022 on Windows |
| Previous Message | Amit Kapila | 2021-11-24 08:54:09 | Re: parallel vacuum comments |