Re: Setting pd_lower in GIN metapage

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Setting pd_lower in GIN metapage
Date: 2017-09-11 07:07:32
Message-ID: CAA4eK1+7EhTaU53oAKpDTHx0+_pKaxJpNm4mS9H1VTqXY_D7EQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

On Mon, Sep 11, 2017 at 7:18 AM, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> On Sun, Sep 10, 2017 at 9:56 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> writes:
>>> On Sun, Sep 10, 2017 at 11:52 AM, Michael Paquier
>>> <michael(dot)paquier(at)gmail(dot)com> wrote:
>>>> Coordinating efforts here would be nice. If you, Amit K, are taking
>>>> care of a patch for btree and hash
>>
>>> I think here we should first agree on what we want to do. Based on
>>> Tom's comment, I was thinking of changing comments in btree/hash part
>>> and additionally for hash indexes, I can see if we can pass
>>> REGBUF_STANDARD for all usages of metapage. I am not sure if we want
>>> similar exercise for btree as well.
>>
>> FWIW, now that we've noticed the discrepancy, I'm for using
>> REGBUF_STANDARD or equivalent for all metapage calls. Even if it
>> saves no space, inconsistency is bad because it's confusing.
>>
>
> Agreed. However, I feel there is no harm in doing in two patches, one
> for hash/btree and second for all other indexes (or maybe separate
> patches for them as well; I haven't yet looked into the work involved
> for other indexes) unless you prefer to do it all at a one-shot.
>

I have prepared separate patches for hash and btree index. I think
for another type of indexes, it is better to first fix the pd_lower
issue.

--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com

Attachment Content-Type Size
change_metapage_usage_hash-v1.patch application/octet-stream 1.2 KB
change_metapage_usage_btree-v1.patch application/octet-stream 2.9 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Rafia Sabih 2017-09-11 07:10:35 Re: [POC] Faster processing at Gather node
Previous Message Amit Langote 2017-09-11 07:04:05 Re: Partition-wise join for join between (declaratively) partitioned tables