Re: Adding a LogicalRepWorker type field

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Peter Smith <smithpb2250(at)gmail(dot)com>
Cc: Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Adding a LogicalRepWorker type field
Date: 2023-08-11 09:33:44
Message-ID: CAA4eK1+zFLVUz_d984v-qJWxct1S+9dQuEh00+iePif67sQXuw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Aug 10, 2023 at 7:50 AM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>
> >
> > * If you do the above then there won't be a need to change the
> > variable name is_parallel_apply_worker in logicalrep_worker_launch.
> >
>
> Done.
>

I don't think the addition of two new macros isTablesyncWorker() and
isLeaderApplyWorker() adds much value, so removed those and ran
pgindent. I am planning to commit this patch early next week unless
you or others have any comments.

--
With Regards,
Amit Kapila.

Attachment Content-Type Size
v6-0001-Simplify-determining-logical-replication-worker-t.patch application/octet-stream 7.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Juan José Santamaría Flecha 2023-08-11 09:48:18 Re: Inconsistent results with libc sorting on Windows
Previous Message Peter Smith 2023-08-11 08:58:35 logicalrep_worker_launch -- counting/checking the worker limits