Re: Some doubious code in pgstat.c

On Thu, Nov 5, 2020 at 9:44 AM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>
> On Thu, Nov 5, 2020 at 11:18 AM Kyotaro Horiguchi
> <horikyota(dot)ntt(at)gmail(dot)com> wrote:
> > As another issue, just replace memcpy with strlcpy makes compiler
> > complain of type mismatch, as the first paramter to memcpy had an
> > needless "&" operator. I removed it in this patch.
> >
> > (&msg.m_slotname is a "char (*)[NAMEDATALEN]", not a "char *".)
> >
>
> The patch looks good to me.
>

LGTM as well but the proposed commit message seems to be a bit
unclear. How about something like this:
"Use strlcpy instead of memcpy for copying the slot name in pgstat.c.

There is no outright bug here but it is better to be consistent with
the usage at other places in the same file. In the passing, fix a wrong
Assertion in pgstat_recv_replslot."

--
With Regards,
Amit Kapila.