Re: Skipping logical replication transactions on subscriber side

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Skipping logical replication transactions on subscriber side
Date: 2021-07-01 11:20:14
Message-ID: CAA4eK1+woM2cWGkDzy7JFSze4d8gJy7uBZdyAJVS7pSgcyb+-g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jul 1, 2021 at 1:24 PM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>
> On Wed, Jun 30, 2021 at 8:05 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> > If so, in which cases are you imagining the files to be
> > created, is it in the case of relation message
> > (LOGICAL_REP_MSG_RELATION)? Assuming the previous two statements are
> > correct, this will skip the relation message as well as part of the
> > removal of stream files which might lead to a problem because the
> > publisher won't know that we have skipped the relation message and it
> > won't send it again. This can cause problems while processing the next
> > messages.
>
> Good point. In the current patch, we skip all streamed changes at
> stream_commit/abort but it should apply changes while skipping only
> data-modification changes as we do for non-stream changes.
>

Right.

--
With Regards,
Amit Kapila.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bharath Rupireddy 2021-07-01 12:07:41 Re: Refactor "mutually exclusive options" error reporting code in parse_subscription_options
Previous Message Amit Kapila 2021-07-01 11:07:50 Re: Refactor "mutually exclusive options" error reporting code in parse_subscription_options