| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | John Naylor <john(dot)naylor(at)2ndquadrant(dot)com> |
| Cc: | Mithun Cy <mithun(dot)cy(at)enterprisedb(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: WIP: Avoid creation of the free space map for small tables |
| Date: | 2019-03-08 11:49:06 |
| Message-ID: | CAA4eK1+v335iq=8EukOUHM=6SHesxjbVEwws05CG-chY4FQWyg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Mar 8, 2019 at 5:13 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
>
> Few minor comments:
..
>
> 2.
> +
> + /* Transfer any VM files if we can trust their
> contents. */
> if (vm_crashsafe_match)
>
> 3. Can we add a note about this in the Notes section of pg_upgrade
> documentation [1]?
>
> This comment line doesn't seem to be related to this patch. If so, I
> think we can avoid having any additional change which is not related
> to the functionality of this patch. Feel free to submit it
> separately, if you think it is an improvement.
>
oops, I have messed up the above comments. The paragraph starting
with "This comment line doesn't ..." is for comment number-2.
--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Banck | 2019-03-08 11:51:21 | Re: Online verification of checksums |
| Previous Message | Amit Kapila | 2019-03-08 11:45:31 | Re: WIP: Avoid creation of the free space map for small tables |