| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
| Cc: | Greg Nancarrow <gregn4422(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com>, "osumi(dot)takamichi(at)fujitsu(dot)com" <osumi(dot)takamichi(at)fujitsu(dot)com>, Alexey Lesovsky <lesovsky(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Skipping logical replication transactions on subscriber side |
| Date: | 2021-12-17 10:12:10 |
| Message-ID: | CAA4eK1+tikFoJEj5CMw5e6=a=YqCbUCxccqywRAbuCrcfpc8Xg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Dec 17, 2021 at 3:23 PM Peter Eisentraut
<peter(dot)eisentraut(at)enterprisedb(dot)com> wrote:
>
> On 13.12.21 04:12, Greg Nancarrow wrote:
> > (ii) "Setting -1 means to reset the transaction ID"
> >
> > Shouldn't it be explained what resetting actually does and when it can
> > be, or is needed to be, done? Isn't it automatically reset?
> > I notice that negative values (other than -1) seem to be regarded as
> > valid - is that right?
> > Also, what happens if this option is set multiple times? Does it just
> > override and use the latest setting? (other option handling errors out
> > with errorConflictingDefElem()).
> > e.g. alter subscription sub skip (xid = 721, xid = 722);
>
> Let's not use magic numbers and instead use a syntax that is more
> explicit, like SKIP (xid = NONE) or RESET SKIP or something like that.
>
+1 for using SKIP (xid = NONE) because otherwise first we need to
introduce RESET syntax for this command.
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ronan Dunklau | 2021-12-17 10:20:11 | Re: Use generation context to speed up tuplesorts |
| Previous Message | Amit Kapila | 2021-12-17 10:09:12 | Re: row filtering for logical replication |