Re: [PATCH] Add `truncate` option to subscription commands

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: David Christensen <david(at)endpoint(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Add `truncate` option to subscription commands
Date: 2020-10-10 05:14:19
Message-ID: CAA4eK1+n5V_hE+vvKz9Nn1z3S9D6RArL3Nw5MK3yx2pVcicq7Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Oct 10, 2020 at 12:24 AM David Christensen <david(at)endpoint(dot)com> wrote:
>
> -hackers,
>
> Enclosed find a patch to add a “truncate” option to subscription commands.
>
> When adding new tables to a subscription (either via `CREATE SUBSCRIPTION` or `REFRESH PUBLICATION`), tables on the target which are being newly subscribed will be truncated before the data copy step. This saves explicit coordination of a manual `TRUNCATE` on the target tables and allows the results of the initial data sync to be the same as on the publisher at the time of sync.
>

So IIUC, this will either truncate all the tables for a particular
subscription or none? Is it possible that the user wants some of
those tables to be truncated which made me think what exactly made you
propose this feature? Basically, is it from user complaint, or is it
some optimization that you think will be helpful to users?

--
With Regards,
Amit Kapila.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2020-10-10 05:25:25 Re: SEARCH and CYCLE clauses
Previous Message Amit Kapila 2020-10-10 04:32:46 Re: Parallel INSERT (INTO ... SELECT ...)