From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
---|---|
To: | "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com> |
Cc: | Peter Smith <smithpb2250(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: "ERROR: deadlock detected" when replicating TRUNCATE |
Date: | 2021-05-21 10:21:35 |
Message-ID: | CAA4eK1+kZ_-MXUBOgJ9Bju9=CpuSt_4kf1ETWGmyPY9NtnXZ9A@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, May 20, 2021 at 12:46 PM tanghy(dot)fnst(at)fujitsu(dot)com
<tanghy(dot)fnst(at)fujitsu(dot)com> wrote:
>
> On Thursday, May 20, 2021 3:05 PM, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> > Okay, I have prepared the patches for all branches (11...HEAD). Each
> > version needs minor changes in the test, the code doesn't need much
> > change. Some notable changes in the tests:
> > 1. I have removed the conf change for max_logical_replication_workers
> > on the publisher node. We only need this for the subscriber node.
> > 2. After creating the new subscriptions wait for initial
> > synchronization as we do for other tests.
> > 3. synchronous_standby_names need to be reset for the previous test.
> > This is only required for HEAD.
> > 4. In PG-11, we need to specify the application_name in the connection
> > string, otherwise, it took the testcase file name as application_name.
> > This is the same as other tests are doing in PG11.
> >
> > Can you please once verify the attached patches?
>
> I have tested your patches for all branches(11...HEAD). All of them passed. B.T.W, I also confirmed that the bug exists in these branches without your fix.
>
> The changes in tests LGTM.
> But I saw whitespace warnings when applied the patches for PG11 and PG12, please take a look at this.
>
Thanks, I have pushed after fixing the whitespace warning.
--
With Regards,
Amit Kapila.
From | Date | Subject | |
---|---|---|---|
Next Message | Bharath Rupireddy | 2021-05-21 10:26:31 | Re: Alias collision in `refresh materialized view concurrently` |
Previous Message | Amit Kapila | 2021-05-21 10:16:30 | Re: Parallel Inserts in CREATE TABLE AS |