Re: Re: [COMMITTERS] pgsql: Map basebackup tablespaces using a tablespace_map file

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Re: [COMMITTERS] pgsql: Map basebackup tablespaces using a tablespace_map file
Date: 2015-08-08 04:14:34
Message-ID: CAA4eK1+gMbD6Y=Ht6AWGkdQKmn2oAETQce_73iOC_XWjLsSiNg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Tue, Aug 4, 2015 at 8:45 AM, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Mon, Aug 3, 2015 at 7:44 PM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>
> > BTW, while reading the code related to tablespace_map, I found that
> > CancelBackup() emits the WARNING message "online backup mode was not
canceled"
> > when rename() fails. Isn't this confusing (or incorrect)?
>
> Yes, it looks confusing.
>

Though this is *not* a major bug, still I feel it is better to do something
about it. So ideally, this should be tracked in 9.5 Open Items, but
if you think otherwise, then also I think we should track it as part
of CF for 9.6, anybody having any opinion?

With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Fabien COELHO 2015-08-08 04:44:58 Re: pgsql: Fix bug slowing down pgbench when -P is used.
Previous Message Andres Freund 2015-08-07 23:19:36 pgsql: Fix bug slowing down pgbench when -P is used.

Browse pgsql-hackers by date

  From Date Subject
Next Message Noah Misch 2015-08-08 06:30:44 Re: Raising our compiler requirements for 9.6
Previous Message Amit Kapila 2015-08-08 03:06:34 Re: [DESIGN] ParallelAppend