| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | shveta malik <shveta(dot)malik(at)gmail(dot)com> |
| Cc: | "Yu Shi (Fujitsu)" <shiy(dot)fnst(at)fujitsu(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, Ajin Cherian <itsajin(at)gmail(dot)com>, "Wei Wang (Fujitsu)" <wangw(dot)fnst(at)fujitsu(dot)com>, Runqi Tian <runqidev(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, li jie <ggysxcq(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Japin Li <japinli(at)hotmail(dot)com>, rajesh singarapu <rajesh(dot)rs0541(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Zheng Li <zhengli10(at)gmail(dot)com> |
| Subject: | Re: Support logical replication of DDLs |
| Date: | 2023-06-13 05:15:28 |
| Message-ID: | CAA4eK1+edgjZnvwx1OfWjpXjpUtn1YM4rZ6sfdmRpZ_Ofo-Lbw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-general pgsql-hackers |
On Thu, Jun 8, 2023 at 5:32 PM shveta malik <shveta(dot)malik(at)gmail(dot)com> wrote:
>
> On Thu, Jun 8, 2023 at 10:36 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> Please find new set of patches addressing below:
> a) Issue mentioned by Wang-san in [1],
> b) Comments from Peter given in [2]
> c) Comments from Amit given in the last 2 emails.
>
As mentioned previously [1], I think there is a value to allow
appending the options not given in the original statement (say
tablespace) but it would be better to provide additional information
with some subscription option like expanded_mode = on/off. With
expanded_mode = off, we should only WAL log the information required
to construct the original DDL statement.
I think we can now remove ObjTree part of the code as we have seen
that we can form the required jsonb without it as well.
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Wen Yi | 2023-06-13 06:49:02 | Re: How to trace the postgres? |
| Previous Message | Merlin Moncure | 2023-06-13 02:49:14 | Re: Question about where to deploy the business logics for data processing |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2023-06-13 05:46:57 | Re: [PoC] Improve dead tuple storage for lazy vacuum |
| Previous Message | Nathan Bossart | 2023-06-13 05:13:43 | Re: add non-option reordering to in-tree getopt_long |