Re: pg_verify_checksums failure with hash indexes

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>
Subject: Re: pg_verify_checksums failure with hash indexes
Date: 2018-09-04 03:42:26
Message-ID: CAA4eK1+eZx0B02KPkqnz7V=rTvq6GjA=WaxJ5QnA5rZT+PQLrQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Sep 3, 2018 at 7:21 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> writes:
> > AFAICS, this problem exists in 9.6 and prior branches as well,
> > although, I can't test it. I am not sure whether we need to backpatch
> > this beyond 10 (where hash indexes are WAL logged) as prior to that
> > hash-indexes are anyway not-reliable. What's your opinion?
>
> Presumably, any patch for pre-10 would look completely different
> as the hash index code was quite different. I can't see that it's
> worth the development time to do something there, especially if
> you lack an easy way to test.
>

The fix might or might not be different, but lack of test is
definitely the reason for not pursuing it. I have pushed the fix and
back-patched it till 10.

Thanks for the input.

--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2018-09-04 04:08:34 Re: pointless check in RelationBuildPartitionDesc
Previous Message Noah Misch 2018-09-04 01:59:10 Re: [HACKERS] Re: Improve OR conditions on joined columns (common star schema problem)