Re: DOC: pg_publication_rel.prrelid says sequences are possible

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: shveta malik <shveta(dot)malik(at)gmail(dot)com>
Cc: Peter Smith <smithpb2250(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: DOC: pg_publication_rel.prrelid says sequences are possible
Date: 2026-04-02 08:33:09
Message-ID: CAA4eK1+drNVMcEjwLfK4rMPXQUjfoJcZumfouG7VGGVWUy3K4w@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Apr 1, 2026 at 12:35 PM shveta malik <shveta(dot)malik(at)gmail(dot)com> wrote:
>
> On Wed, Apr 1, 2026 at 10:30 AM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
> >
> > Hi.
> >
> > It is my understanding that only tables can exist in the
> > 'pg_publication_rel' catalog.
> >
> > e.g. only for these scenarios:
> > * included tables - when pg_publication.puballtables is false, these
> > are the specified FOR TABLE ... tables
> > * excluded tables - when pg_publication.puballtables is true, these
> > are the specified FOR ALL TABLES EXCEPT (TABLE ...) tables
> >
> > In particular, AFAIK there is no way for sequences to be in the
> > 'pg_publication_rel' catalog. e.g.
> > PG19 only supports "CREATE PUBLICATION ... FOR ALL SEQUENCES", which
> > is indicated by pg_publication.puballsequences.
> > PG19 has no support for "CREATE PUBLICATION ... FOR SEQUENCE seq1,seq2".
> >
> > ~~
> >
> > Meanwhile, the DOCS page for 'pg_publication_rel' catalog [1] since
> > commit 55cefad says that sequences are also possible [2]:
> > ------
> > prrelid oid (references pg_class.oid)
> > Reference to table or sequence
> > ------
> >
> > How are sequences possible? PSA a patch to correct it.
> >
> > Or, am I mistaken here?
> >
>
> You are right, pg_publication_rel can never have a seq entry while
> pg_subscription_rel can have. The patch LGTM.
>

Pushed.

--
With Regards,
Amit Kapila.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Lukas Fittl 2026-04-02 08:50:08 Re: Reduce timing overhead of EXPLAIN ANALYZE using rdtsc?
Previous Message Alvaro Herrera 2026-04-02 08:27:21 Re: Adding REPACK [concurrently]