Re: [PATCH] Fix stale relation close in sequence synchronization

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Ayush Tiwari <ayushtiwari(dot)slg01(at)gmail(dot)com>
Cc: vignesh C <vignesh21(at)gmail(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [PATCH] Fix stale relation close in sequence synchronization
Date: 2026-04-30 11:20:27
Message-ID: CAA4eK1+dMVi9O5tHWuAuVZLEQufY6+UvzZoYx8dSwj0F9FRR9g@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Apr 30, 2026 at 12:16 PM Ayush Tiwari
<ayushtiwari(dot)slg01(at)gmail(dot)com> wrote:
>
> On Thu, 30 Apr 2026 at 11:27, vignesh C <vignesh21(at)gmail(dot)com> wrote:
>>
>>
>> Consider updating the error reported in report_sequence_errors to
>> convey that the failure could be due to either a missing sequence or
>> insufficient privileges (e.g., "missing sequence or insufficient
>> privilege on publisher"). While making this change, also update the
>> missing_seqs_idx variable name and the associated comments to
>> accurately reflect the broader scope of the condition.
>
>
> Agreed.
>

Sequence sync can also be skipped if the same sequence is a temporary
sequence from some other session on publisher. So, the change in v5
was also incomplete if we want to make it more generic than now. I
have pushed v4 for now but if you or Vignesh would like to make the
message more generic, feel free to propose a new patch.

--
With Regards,
Amit Kapila.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Mihail Nikalayeu 2026-04-30 11:24:41 Re: Adding REPACK [concurrently]
Previous Message Jakub Wartak 2026-04-30 11:14:59 md: measure just FileSync() for pgstat_io without FileClose()