From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
---|---|
To: | Andreas Seltenreich <seltenreich(at)gmx(dot)de> |
Cc: | Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [sqlsmith] Failed assertion in parallel worker (ExecInitSubPlan) |
Date: | 2016-05-23 04:03:22 |
Message-ID: | CAA4eK1+cA33KJK2kPvVLeywJD3nyikpjJ1z-XZaDFhTPks4+Jw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Sun, May 22, 2016 at 9:32 PM, Andreas Seltenreich <seltenreich(at)gmx(dot)de>
wrote:
>
> Amit Kapila writes:
>
> > avoid_restricted_clause_below_gather_v1.patch
> > prohibit_parallel_clause_below_rel_v1.patch
>
> I didn't observe any parallel worker related coredumps since applying
> these. The same amount of testing done before applying them yielded
> about a dozend.
>
Thanks for verification.
> Dilip Kumar writes:
>
> > So now its clear that because of sub query pullup, we may get
expression in
> > targetlist while creating single table path list. So we need to avoid
> > parallel plan if it contains expression.
>
> This sounds like a rather heavy restriction though…
>
I think what Dilip means by above statement is to avoid parallel plan if
target list contains parallel unsafe or restricted expressions. We already
restrict generation of parallel plans if qualification for a relation
contains such expressions (refer set_rel_consider_parallel()), so this
doesn't sound to be heavy restriction.
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
From | Date | Subject | |
---|---|---|---|
Next Message | Andreas Seltenreich | 2016-05-23 08:49:15 | Re: [sqlsmith] Failed assertions on parallel worker shutdown |
Previous Message | Noah Misch | 2016-05-23 03:22:18 | Re: new tests post-feature freeze (was pgsql: Add TAP tests for pg_dump) |