| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
| Cc: | Peter Smith <smithpb2250(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Review items for EXCEPT TABLE publication |
| Date: | 2026-09-14 05:43:02 |
| Message-ID: | CAA4eK1+c0C5kNmg5zOU3TcHgQ+h0Ke1wd+JmyeTvt6P5WfweAQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Sep 14, 2026 at 11:04 AM Hayato Kuroda (Fujitsu)
<kuroda(dot)hayato(at)fujitsu(dot)com> wrote:
>
> > Looks good, but isn't it more common for an errhint to say what
> > command to use instead of just "make this happen"?
> >
> > e.g.
> > "First use ALTER PUBLICATION ... to drop the table from the
> > publication, or to remove it from the publication's EXCEPT clause."
>
> Possible, but other lines refer the FULL command in the notation. Like
> ALTER TABLE ... ALTER CONSTRAINT ... INHERIT,
> ALTER DATABASE ... REFRESH COLLATION VERSION,
> ALTER SUBSCRIPTION ... SET PUBLICATION ... WITH (refresh = false).
>
> Based on that current style may be more appropriate unless exact commands
> are referred there.
>
+1. We can use full commands here but that will make the hint longer
than usual cases, so I also would prefer the current message.
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2026-09-14 06:00:17 | Re: Translation of the NextOID message in pg_controldata |
| Previous Message | Hayato Kuroda (Fujitsu) | 2026-09-14 05:34:25 | RE: Review items for EXCEPT TABLE publication |