| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Amit Langote <amitlangote09(at)gmail(dot)com> |
| Cc: | "shiy(dot)fnst(at)fujitsu(dot)com" <shiy(dot)fnst(at)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com> |
| Subject: | Re: Replica Identity check of partition table on subscriber |
| Date: | 2022-06-21 05:29:25 |
| Message-ID: | CAA4eK1+a_uCYMCkrnDntkHOFunrs6yMfXnKc4aSgu-aH0TEmEQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jun 21, 2022 at 8:02 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Tue, Jun 21, 2022 at 7:49 AM Amit Langote <amitlangote09(at)gmail(dot)com> wrote:
> >
> >
> > I think it should spell out REPLICA IDENTITY explicitly to avoid the
> > commit being confused to have to do with "Referential Integrity
> > checking".
> >
>
> This makes sense. I'll take care of this.
>
After pushing this patch, buildfarm member prion has failed.
https://buildfarm.postgresql.org/cgi-bin/show_history.pl?nm=prion&br=HEAD
It seems to me that the problem could be due to the reason that the
entry returned by logicalrep_partition_open() may not have the correct
value for localrel when we found the entry and localrelvalid is also
true. The point is that before this commit we never use localrel value
from the rel entry returned by logicalrep_partition_open. I think we
need to always update the localrel value in
logicalrep_partition_open().
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyotaro Horiguchi | 2022-06-21 05:56:40 | Re: Using PQexecQuery in pipeline mode produces unexpected Close messages |
| Previous Message | Thomas Munro | 2022-06-21 05:22:05 | Re: Is RecoveryConflictInterrupt() entirely safe in a signal handler? |