Re: PostgreSQL in Windows console and Ctrl-C

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, Christian Ullrich <chris(at)chrullrich(dot)net>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: PostgreSQL in Windows console and Ctrl-C
Date: 2014-04-12 04:05:49
Message-ID: CAA4eK1+ZmVDDjwDORmSBXDGx6Z2KpUqVaQHWN-UdhHr6k6aZ3w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Apr 11, 2014 at 4:42 PM, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
> On 04/11/2014 01:35 AM, Amit Kapila wrote:
>> I don't think this is a complete fix, for example what about platform
>> where
>> _CreateRestrictedToken() is not supported. For Example, the current
>> proposed fix will not work for below case:
>>
>> if (_CreateRestrictedToken == NULL)
>> {
>> /*
>> * NT4 doesn't have CreateRestrictedToken, so just call ordinary
>> * CreateProcess
>> */
> Are we really supporting NT4 any more? Even XP is about to be at end of
> support from Microsoft.

In Docs, it is mentioned as Windows (Win2000 SP4 and later).
Now what shall we do with this part of code, shall we keep it as it is and
just fix in other part of code or shall we remove this part of code?

Another thing to decide about this fix is that whether it is okay to fix it
for CTRL+C and leave the problem open for CTRL+BREAK?
(The current option used (CREATE_NEW_PROCESS_GROUP) will handle
only CTRL+C).

With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2014-04-12 05:32:03 Re: Dynamic Shared Memory stuff
Previous Message Stephen Frost 2014-04-12 03:22:50 Re: WIP patch (v2) for updatable security barrier views