Re: New IndexAM API controlling index vacuum strategies

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Peter Geoghegan <pg(at)bowt(dot)ie>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Noah Misch <noah(at)leadboat(dot)com>, Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>
Subject: Re: New IndexAM API controlling index vacuum strategies
Date: 2021-04-07 10:01:37
Message-ID: CAA4eK1+Y3a-iSgd9Xmd4=Y+k_Y6ObMVFs7ipXGSMsMY_j-vKQg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Apr 6, 2021 at 5:49 AM Peter Geoghegan <pg(at)bowt(dot)ie> wrote:
>
> On Mon, Apr 5, 2021 at 5:09 PM Peter Geoghegan <pg(at)bowt(dot)ie> wrote:
> > Oh yeah. "static BufferAccessStrategy vac_strategy" is guaranteed to
> > be initialized to 0, simply because it's static and global. That
> > explains it.
>
> So do we need to allocate a strategy in workers now, or leave things
> as they are/were?
>
> I'm going to go ahead with pushing my commit to do that now, just to
> get the buildfarm green. It's still a bug in Postgres 13, albeit a
> less serious one than I first suspected.
>

I have started a separate thread [1] to fix this in PG-13.

[1] - https://www.postgresql.org/message-id/CAA4eK1KbmJgRV2W3BbzRnKUSrukN7SbqBBriC4RDB5KBhopkGQ%40mail.gmail.com

--
With Regards,
Amit Kapila.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2021-04-07 10:23:42 Re: Yet another fast GiST build
Previous Message Amit Kapila 2021-04-07 10:00:15 Set access strategy for parallel vacuum workers